Before this fix, the dialog was not allowing directory browsing.
In previous versions of GTK, the dialog used to work.
Why it stopped working is not known.
While one could be safe to assume that first input is read,
then symlink target is copied to user-mode, it causes compiler
warning.
So, don't reuse the symlink filename buffer for storing symlink
target.
../daemon/procfs.c:155:28: error: passing argument 2 to restrict-qualified parameter aliases with argument 1 [-Werror=restrict]
155 | ret = readlink(g_buffer, g_buffer, sizeof(g_buffer));
| ~~~~~~~~ ^~~~~~~~
sys-libs/glibc-2.30-r8 (armv7a, but ISA probably does not matter)
gcc (Gentoo 9.3.0 p2) 9.3.0
../daemon/escape.c: In function ‘escape’:
../daemon/escape.c:49:10: error: this statement may fall through [-Werror=implicit-fallthrough=]
49 | if ((flags & LADISH_ESCAPE_FLAG_OTHER) == 0)
| ^
../daemon/escape.c:53:5: note: here
53 | case '<': /* invalid attribute value char (XML spec) */
| ^~~~
gcc (Gentoo 9.3.0 p2) 9.3.0
../daemon/sigsegv.c: В функции ‘signal_segv’:
../daemon/sigsegv.c:114:9: ошибка: формат ‘%02d’ предполагает тип ‘int’, но аргумент 6 имеет тип ‘size_t’
* Take advantage of gcc printf format checks
* Move code dependent on log level to log.c
This is a basis for runtime logging tweaks.
* Remove the now useless LADISH_DEBUG defines
Under some systems libasound.so is not available by default (reserved to devel packages), which will trigger some LD_PRELOAD warnings.
Bristol fails to start because of this, as it's not expecting such output when first requesting jack sample-rate and buffer-size.
Adding .2 to the library name ensures that the alsa library is always present on non-devel systems, and fixes the Bristol issue.
The exit code detection for apps ran in terminal is not working,
at least with xterm. xterm doesnt seem to be able to return exit
code of its child process.