LADI
/
ladish
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix use of unintialized memory 

old_project_xxx members are used in ladish_room_save_complete()
This commit is contained in:
Nedko Arnaudov 2012-11-19 04:06:51 +02:00
parent 676db75cb1
commit a42ac047af
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
daemon/room_save.c
View File

@ -2,7 +2,7 @@
/*
* LADI Session Handler (ladish)
*
* Copyright (C) 2010,2011 Nedko Arnaudov <nedko@arnaudov.name>
* Copyright (C) 2010,2011,2012 Nedko Arnaudov <nedko@arnaudov.name>
*
**************************************************************************
* This file contains the parts of room object implementation
@ -384,6 +384,9 @@ ladish_room_save_project(
ctx_ptr->context = context;
ctx_ptr->callback = callback;
ctx_ptr->old_project_dir = room_ptr->project_dir;
ctx_ptr->old_project_name = room_ptr->project_name;
/* project has either both name and dir no none of them */
ASSERT((room_ptr->project_dir == NULL && room_ptr->project_name == NULL) || (room_ptr->project_dir != NULL && room_ptr->project_name != NULL));
first_time = room_ptr->project_dir == NULL;
@ -458,8 +461,6 @@ ladish_room_save_project(
goto destroy_ctx;
}
ctx_ptr->old_project_dir = room_ptr->project_dir;
ctx_ptr->old_project_name = room_ptr->project_name;
room_ptr->project_name = ctx_ptr->project_name;
room_ptr->project_dir = ctx_ptr->project_dir;