Commit Graph

516 Commits

Author SHA1 Message Date
Nedko Arnaudov ebce813997 Fix unused-parameter warnings in plain C code 2012-12-02 23:50:05 +02:00
Nedko Arnaudov abf820278b extra compiler warnings 2012-12-02 21:39:51 +02:00
Nedko Arnaudov 73acf78b8d Improve logging
* Take advantage of gcc printf format checks
 * Move code dependent on log level to log.c
   This is a basis for runtime logging tweaks.
 * Remove the now useless LADISH_DEBUG defines
2012-12-02 20:24:22 +02:00
Nedko Arnaudov 9bbfff1608 Fix log calls
* Remove useless ifdefs for LADISH_DEBUG
 * Fix formatting errors
2012-12-02 20:24:22 +02:00
Nedko Arnaudov 702b287d35 Fix memory leak when a2j mapping fails
alsa_client_name and alsa_client_port are set but is_a2j is set to false
2012-11-19 06:54:49 +02:00
Nedko Arnaudov 84a338dfd2 Don't set garbge pid to ports (either new or existing ones) 2012-11-19 06:42:13 +02:00
Nedko Arnaudov e99af5f8be Fix undefined return value in case of error 2012-11-19 06:42:04 +02:00
Nedko Arnaudov 871dace9c5 Improve assert and fix clang static analyzer report 2012-11-19 06:00:43 +02:00
Nedko Arnaudov 0660f36589 Fix use of uninitialized memory in chdir() failure handling code path 2012-11-19 05:49:33 +02:00
Nedko Arnaudov ad6dbf1392 Fix memory leak on procfs read() failure 2012-11-19 05:32:21 +02:00
Nedko Arnaudov 61c34054e1 Fix error handling 2012-11-19 05:18:05 +02:00
Nedko Arnaudov 136d9d1d45 fix use of uninitialized memory in malloc failure handling code path 2012-11-19 04:47:07 +02:00
Nedko Arnaudov a42ac047af Fix use of unintialized memory
old_project_xxx members are used in ladish_room_save_complete()
2012-11-19 04:06:51 +02:00
Nedko Arnaudov c2fc519d5c fix double free in malloc failure handling code path 2012-11-17 14:48:48 +02:00
falkTX 88aaa609e2 preload libasound.so.2 instead of libasound.so
Under some systems libasound.so is not available by default (reserved to devel packages), which will trigger some LD_PRELOAD warnings.
Bristol fails to start because of this, as it's not expecting such output when first requesting jack sample-rate and buffer-size.
Adding .2 to the library name ensures that the alsa library is always present on non-devel systems, and fixes the Bristol issue.
2012-11-11 22:59:32 +00:00
Nedko Arnaudov 2c3c3f0290 Don't notify user about unexpectedly stopped apps that returned 0 exit code. Fixes #197
The exit code detection for apps ran in terminal is not working,
at least with xterm. xterm doesnt seem to be able to return exit
code of its child process.
2012-10-09 02:32:42 +03:00
Nedko Arnaudov a2a17cd392 add includes for getrlimit 2012-10-07 14:06:59 +03:00
Nedko Arnaudov ce273d9e58 Fix logging from child processes
After fork the log file descriptor is closed
2012-09-08 04:14:47 +03:00
Nedko Arnaudov 9742a120cd Catch last words before children death 2012-09-08 04:13:30 +03:00
Nedko Arnaudov cd3684d1ad cdbus: macros for defining interfaces with default handler 2011-11-09 02:59:26 +02:00
Nedko Arnaudov a0738fe6e7 dbus/ -> cdbus/ 2011-11-09 02:45:13 +02:00
Nedko Arnaudov 4202100444 cdbus: prefix macros with CDBUS_ 2011-11-09 02:38:22 +02:00
Nedko Arnaudov 9202dae129 cdbus: remove lash traces
* rename cdbus header include guards to use CDBUS_ instead of LASH_DBUS_
 * remove dbus/error.h and dbus/error.c

error.h contained lash/ladish specific error strings and
lash_dbus_error() prototype. lash_dbus_error() is renamed to
cdbus_error() and its implementation is moved to dbus/method.c. The
D-Bus error strings that have DBUS_ERROR_XXX matches are removed and
their uses are switched to the libdbus variants. The ladish specific
error strings are moved to dbus_constants.h
2011-11-06 00:10:10 +02:00
Nedko Arnaudov 640ca88481 Implement JS delay workaround. #187
yoshimi-0.060.10 jack session implementation is broken. Save complete
reply is sent from the jack session callback but the actual save is
made asynchronously, in the main thread, on next main loop iteration.

This changeset implements workaround for app bugs like this.
User is able to set JS delay in seconds. Default is zero.
2011-10-23 03:54:04 +03:00
Nedko Arnaudov 17e12e1e84 remove unused variable
gcc 4.6 was reporting warning:
../daemon/room_save.c:372:8: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable]
2011-10-15 20:00:46 +03:00
Nedko Arnaudov 6df7809837 Call the save completion callback when ladish_js_save_app() fails. #185 2011-10-11 03:52:58 +03:00
Nedko Arnaudov 88712ad5e5 simplify ladish_room_save_project() error handling
the callback is always called. the function has not return value anymore.
2011-10-11 03:46:59 +03:00
Nedko Arnaudov 8ba2d5f991 daemon: fix function name
ladish_room_project_complete -> ladish_room_project_save_complete
2011-10-11 03:41:20 +03:00
Nedko Arnaudov 69dd3f5611 fix warnings when building with disabled stacktrace 2011-10-10 04:42:56 +03:00
Nedko Arnaudov f14ff0f10e ladishd: when starting apps, always use shell. Fix #179
terminal emulators expect split commandline.
without terminal emulator and without shell, commandline must be split.
2011-10-02 16:03:26 +03:00
Nedko Arnaudov f42b4fbef7 operational jack session implementation 2011-10-02 00:47:50 +03:00
Nedko Arnaudov 5483a52daf ladishd: async app supervisor save. async studio and project save. 2011-09-26 05:03:57 +03:00
Nedko Arnaudov 3b69e81c76 ladishd: fix bug in currently unused code 2011-09-10 15:18:59 +03:00
Nedko Arnaudov 6aa44e9ab9 dbus_ -> cdbus_ renames 2011-09-10 03:35:48 +03:00
Nedko Arnaudov 8bc41a21a0 fix more gcc-4.6 warnings
../conf.c:153:7: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
../jmcore.c:214:7: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
../daemon/cmd_save_project.c:45:8: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
../daemon/main.c:288:7: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
2011-09-10 02:04:28 +03:00
Nedko Arnaudov 68716ee66c ladishd: fix invalid cast and log
levels are strings now and must be logged as such
2011-09-10 02:01:38 +03:00
Nedko Arnaudov 42cdd70e33 Make the app supervisor interface versioned
unreleased apps using latest api MAY check for interface version

released apps using latest api SHOULD check for interface version
2011-09-10 01:06:08 +03:00
Nedko Arnaudov 8100ea334e ladishd: make the D-Bus app supervisor API backward compatible
In 997630bfb7 the API changed because of LASH and
jack-session support. The level app property was switched from uint8 to string.
However, some externally maintained frontends (claudia, klaudia and festige) use
the 0.3 API.

This changeset restores the 0.3 API and extends it with new functions and signals,
ones that use string instead of uint8 level.
2011-09-06 19:02:55 +03:00
Nedko Arnaudov 2b66a82e9a ladishd: new function - ladish_js_save_app() 2011-09-03 03:17:49 +03:00
Nedko Arnaudov 1113f0e9d3 ladish_app_send_signal() expectes app be in started state 2011-08-04 04:21:01 +03:00
Nedko Arnaudov 026659406a LASH support in ladishd 2011-08-04 02:59:01 +03:00
Nedko Arnaudov 53845918fe prefix cdbus global vars with unique prefix 2011-07-31 20:04:01 +03:00
Nedko Arnaudov 934fa96a15 ladishd: rename ladish_app_supervisor_save_L1() to ladish_app_supervisor_initiate_save()
This function will initiate save for LASH and JACK session apps as well.
2011-07-30 22:00:29 +03:00
Nedko Arnaudov a07766fb0a use empty xml element tag syntax for ports with empty dicts
a2j port dict entry is not actually saved,
so the empty element tag syntax has to be used.
2011-07-30 03:59:19 +03:00
Nedko Arnaudov 997630bfb7 use strings for app levels
With jack-session on the manege, strict L0-L3 classification
does not reflect the actual situation. LASH and jack-session
are still L2 though.
2011-07-28 15:15:47 +03:00
Nedko Arnaudov 78f07f7ad1 remove empty client functionality 2011-06-07 04:11:59 +03:00
Nedko Arnaudov 60aaa492db Make alsapid work when libasound is loaded with dlopen(). Fix for #180
when alsapid is preloaded libasound is not loaded yet
for some unknown reason, late call to dlvsym() fails as well,
at least for mididings (python loads _mididings.so that
implicitly loads libasound.so)

this changeset implements the late symbol lookup,
because it makes the code smaller

the actual fix is to LD_PRELOAD libasound.so as well
2011-06-03 00:44:00 +03:00
Nedko Arnaudov f33b58ac85 new vclient and move port functionality 2011-06-01 06:12:54 +03:00
Nedko Arnaudov beef6e7d44 join vclients functionality 2011-06-01 05:37:02 +03:00
Nedko Arnaudov 0bb1d523d7 vclient rename 2011-06-01 04:48:53 +03:00