From 20ebf9ee7c92f45369bd8786db43c057abab4266 Mon Sep 17 00:00:00 2001 From: Nedko Arnaudov Date: Tue, 24 Aug 2010 20:08:12 +0300 Subject: [PATCH] Fix buffer overflow if pid_t is smaller than 64bits --- proxies/jack_proxy.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/proxies/jack_proxy.c b/proxies/jack_proxy.c index c5ad06e7..80c9cfdd 100644 --- a/proxies/jack_proxy.c +++ b/proxies/jack_proxy.c @@ -159,7 +159,15 @@ jack_proxy_get_client_pid( uint64_t client_id, pid_t * pid_ptr) { - return dbus_call(JACKDBUS_SERVICE_NAME, JACKDBUS_OBJECT_PATH, JACKDBUS_IFACE_PATCHBAY, "GetClientPID", "t", &client_id, "x", pid_ptr); + int64_t pid; + + if (!dbus_call(JACKDBUS_SERVICE_NAME, JACKDBUS_OBJECT_PATH, JACKDBUS_IFACE_PATCHBAY, "GetClientPID", "t", &client_id, "x", &pid)) + { + return false; + } + + *pid_ptr = pid; + return true; } bool