The previous style(s) used in most places here violates the C standard, and in
practice can trigger -Wreserved-id-macro in clang for client code. So, switch
to a conventional style that doesn't trigger warnings (and is supported by
tools like clang-tidy).
types.h:
Remove the definition of `jack_native_thread_t` as we will be relying on
the one from systemdeps.h.
{jack,thread}.h:
Include systemdeps.h for definition of `jack_native_thread_t`.
With the current code, packed structs lead to unaligned memory access,
thus causing SIGBUS on ARM.
Let's disable packing on ARM for now. Since it's only used for mixed
32/64bit jackd installations and we're not facing such a scenario on
ARM, there's little use to worry more atm.
(Commit message copied from jackd2's 2f7d512b, since it's the same
problem)
All users of POST_PACKED_STRUCTURE also include <jack/types.h>, so to
avoid code duplication, we move the definition into a single place.
Signed-off-by: Adrian Knoth <adi@drcomp.erfurt.thur.de>
Nedko Arnaudov
David Robillard
David Runge
Matthias Geier
Matthew Persing
Paul Davis
Adrian Knoth