1
Fork 0

Remove useless PluginManager::serializePlugin()

This commit is contained in:
gvnnz 2023-06-11 16:49:03 +02:00
parent c5f1e43764
commit f6631ece91
3 changed files with 5 additions and 13 deletions

View File

@ -29,6 +29,7 @@
#include "core/engine.h"
#include "core/kernelAudio.h"
#include "core/mixer.h"
#include "core/plugins/pluginFactory.h"
#include "utils/fs.h"
namespace giada::m
@ -159,6 +160,7 @@ std::unique_ptr<Plugin> PluginsApi::deserialize(const Patch::Plugin& pplugin)
const int sampleRate = m_kernelAudio.getSampleRate();
const int bufferSize = m_kernelAudio.getBufferSize();
return m_pluginManager.deserializePlugin(pplugin, sampleRate, bufferSize, m_model.get().sequencer);
std::unique_ptr<juce::AudioPluginInstance> pi = m_pluginManager.makeJucePlugin(pplugin.path, sampleRate, bufferSize);
return pluginFactory::deserializePlugin(pplugin, std::move(pi), m_model.get().sequencer, sampleRate, bufferSize);
}
} // namespace giada::m

View File

@ -163,15 +163,6 @@ const Patch::Plugin PluginManager::serializePlugin(const Plugin& p) const
/* -------------------------------------------------------------------------- */
std::unique_ptr<Plugin> PluginManager::deserializePlugin(const Patch::Plugin& p,
int sampleRate, int bufferSize, const model::Sequencer& sequencer)
{
std::unique_ptr<juce::AudioPluginInstance> pi = makeJucePlugin(p.path, sampleRate, bufferSize);
return pluginFactory::deserializePlugin(p, std::move(pi), sequencer, sampleRate, bufferSize);
}
/* -------------------------------------------------------------------------- */
std::vector<Plugin*> PluginManager::clonePlugins(const std::vector<Plugin*>& source,
int sampleRate, int bufferSize, model::Model& model)
{

View File

@ -108,11 +108,10 @@ public:
std::unique_ptr<juce::AudioPluginInstance> makeJucePlugin(const std::string& pid, int sampleRate, int bufferSize);
/* (de)serializePlugin
/* serializePlugin
Transforms patch data into a Plugin object and vice versa. */
const Patch::Plugin serializePlugin(const Plugin& p) const;
std::unique_ptr<Plugin> deserializePlugin(const Patch::Plugin&, int sampleRate, int bufferSize, const model::Sequencer&);
const Patch::Plugin serializePlugin(const Plugin& p) const;
/* clonePlugins
Clones all plugins in the Plugin vector passed in as a parameter. Returns a