1
Fork 0

Remove useless method PluginsApi::deserialize()

This commit is contained in:
gvnnz 2023-06-11 17:03:34 +02:00
parent 452fbef7fd
commit 51d38349a9
3 changed files with 4 additions and 12 deletions

View File

@ -154,13 +154,4 @@ const Patch::Plugin PluginsApi::serialize(const Plugin& p) const
{
return m_pluginManager.serializePlugin(p);
}
std::unique_ptr<Plugin> PluginsApi::deserialize(const Patch::Plugin& pplugin)
{
const int sampleRate = m_kernelAudio.getSampleRate();
const int bufferSize = m_kernelAudio.getBufferSize();
std::unique_ptr<juce::AudioPluginInstance> pi = m_pluginManager.makeJucePlugin(pplugin.path, sampleRate, bufferSize);
return pluginFactory::deserializePlugin(pplugin, std::move(pi), m_model.get().sequencer, sampleRate, bufferSize);
}
} // namespace giada::m

View File

@ -63,8 +63,7 @@ public:
void scan(const std::string& dir, const std::function<void(float)>& progress);
void process(mcl::AudioBuffer& outBuf, const std::vector<Plugin*>&, juce::MidiBuffer* events = nullptr);
const Patch::Plugin serialize(const Plugin&) const;
std::unique_ptr<Plugin> deserialize(const Patch::Plugin&);
const Patch::Plugin serialize(const Plugin&) const;
private:
KernelAudio& m_kernelAudio;

View File

@ -31,6 +31,7 @@
#include "core/midiSynchronizer.h"
#include "core/model/model.h"
#include "core/patchFactory.h"
#include "core/plugins/pluginFactory.h"
#include "core/waveFactory.h"
#include "utils/fs.h"
#include "utils/log.h"
@ -219,7 +220,8 @@ StorageApi::LoadState StorageApi::loadPatch(const Patch& patch)
m_model.getAllPlugins().clear();
for (const Patch::Plugin& pplugin : patch.plugins)
{
std::unique_ptr<Plugin> p = m_engine.getPluginsApi().deserialize(pplugin);
std::unique_ptr<juce::AudioPluginInstance> pi = m_pluginManager.makeJucePlugin(pplugin.path, sampleRate, bufferSize);
std::unique_ptr<Plugin> p = pluginFactory::deserializePlugin(pplugin, std::move(pi), m_model.get().sequencer, sampleRate, bufferSize);
if (!p->valid)
state.missingPlugins.push_back(pplugin.path);
m_model.getAllPlugins().push_back(std::move(p));